Remove DLL_LOCAL and DLL_IMPORT #25577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This macro is unused.
This macro doesn't appear to be providing any value, and make some compilation harder.
|
|
mspang
approved these changes
Mar 8, 2023
|
PR #25577: Size comparison from 43d45ef to 4c154b4 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
nivi-apple,
pjzander-signify,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
vijs,
vivien-apple,
woody-apple and
xylophone21
|
PR #25577: Size comparison from 43d45ef to 33a47e9 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
ksperling-apple
approved these changes
Mar 14, 2023
|
PR #25577: Size comparison from e778a03 to 76bd65e Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Remove DLL_IMPORT macro This macro is unused. * Remove DLL_LOCAL macro This macro doesn't appear to be providing any value, and make some compilation harder. * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DLL_IMPORT is unused.
DLL_LOCAL was imported from baseline code and hasn't been considered properly for Matter. Only a handful of entrypoints are using this with no consistency and it can cause linker errors.